feat(reports): surface attestation PDF + OSCAL SAR downloads in the UI#645
Merged
Merged
Conversation
The attestation report detail offered only CSV (primary) + JSON, leaving the OSCAL SAR (B2) and PDF cover (B3b) faces reachable by API only. Add a secondaryFaces list, keyed on the resolved report kind, that renders extra download buttons: - Attestation: PDF (the bounded cover) + OSCAL SAR (the fleet assessment-results), beside the primary CSV and JSON. - Executive: none (its PDF is the primary). The extra controls share the onDownload handler, the in-flight downloading state, and the downloadError surface; downloadReportFace's format union gains 'oscal_sar'. Spec frontend-reports v1.7.0: C-10 + AC-11 (source-inspection test).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attestation report detail offered only CSV (primary) + JSON, leaving the OSCAL SAR (#643) and PDF cover (#644) faces reachable by API only. This wires them into the download UI so all three attestation faces are usable.
A
secondaryFaceslist, keyed on the resolved report kind, renders extra download buttons:[Download CSV](primary)[PDF][OSCAL SAR][JSON][Verify][Download PDF](primary)[JSON][Verify]— no extrasThe extra controls share the
onDownloadhandler, the in-flightdownloadingstate, and thedownloadErrorsurface;downloadReportFace's format union gains'oscal_sar'.Spec / tests
frontend-reportsv1.7.0: new C-10 + AC-11 (source-inspection test asserting the kind-keyedsecondaryFaceslist, the PDF + OSCAL SAR entries, the mapped buttons, and the widened format union).tsc/eslint/prettierclean;vitest run tests/pages/reports.test.ts11/11;specter check111 specs structural + 0 annotation errors.Validation